From 0d2d1904b1c116afd74042738898ee624c00d853 Mon Sep 17 00:00:00 2001 From: Olivier Brunel Date: Tue, 15 Oct 2013 15:07:28 +0200 Subject: [PATCH] treestore: Fix segfault when reordering non-existing children Calling gtk_tree_store_reorder() on a node without children would cause a segfault; Fixes https://bugzilla.gnome.org/show_bug.cgi?id=698396 Signed-off-by: Olivier Brunel --- gtk/gtktreestore.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gtk/gtktreestore.c b/gtk/gtktreestore.c index a6e47af398..ba9c6b3c49 100644 --- a/gtk/gtktreestore.c +++ b/gtk/gtktreestore.c @@ -2280,6 +2280,12 @@ gtk_tree_store_reorder (GtkTreeStore *tree_store, else level = G_NODE (parent->user_data)->children; + if (G_UNLIKELY (!level)) + { + g_warning ("%s: Cannot reorder, parent has no children", G_STRLOC); + return; + } + /* count nodes */ node = level; while (node) -- 2.30.2